Add some ssl support #1
Open
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemd
requested changes
Sep 5, 2021
Comment on lines
+38
to
+43
| .option('ssl', { | ||
| alias: 's', | ||
| describe: 'Suppress ssl issues', | ||
| type: 'boolean', | ||
| default: false | ||
| }) |
Owner
There was a problem hiding this comment.
let's name this option strict-ssl-verification and it's default should be true
Comment on lines
+95
to
+96
| const httpsAgent = new https.Agent({ rejectUnauthorized: false }); | ||
| const opts = argv.ssl ? { body: fileContents, agent: httpsAgent } : { body: fileContents }; |
Owner
There was a problem hiding this comment.
Suggested change
| const httpsAgent = new https.Agent({ rejectUnauthorized: false }); | |
| const opts = argv.ssl ? { body: fileContents, agent: httpsAgent } : { body: fileContents }; | |
| const agent = new https.Agent({ rejectUnauthorized: !argv.strictSslVerification }); | |
| const opts = Object.assign({body: fileContents}, argv.strictSslVerification ? {} : { agent }); |
Comment on lines
+35
to
+36
| "inquirer": "^5.1.0", | ||
| "https": "^1.0.0" |
Owner
There was a problem hiding this comment.
since we are in nodejs environment, we don't need this dependency
Suggested change
| "inquirer": "^5.1.0", | |
| "https": "^1.0.0" | |
| "inquirer": "^5.1.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some SSL support to make the CLI a little more secure :)
With Basic Authentication set on an HTTPS WebDav server like:
https://bla:bla@webdav.geo.com/bucketthe following exception would be raised by thenode-fetchmodule during file transfer.Error
This PR includes new proposed usage:
Commands
webdav-watch watch --folder ./music --s false --remote https://bla:bla@webdav.geo.com/bucketOR
webdav-watch watch --folder ./music --ssl false --remote https://bla:bla@webdav.geo.com/bucketAND
webdav-watch watch --folder ./music --s true --remote https://bla:bla@webdav.geo.com/bucketOR
webdav-watch watch --folder ./music --ssl true --remote https://bla:bla@webdav.geo.com/bucketCommand using config
Example Configs